search

js-data / js-data-angular

Angular wrapper for js-data
http://www.js-data.io/docs/js-data-angular
MIT License
973 stars 77 forks source link

BindOne recomputing computed properties #347

Closed kenjiqq closed 8 years ago

kenjiqq commented 8 years ago

Hi. We're in the process of upgrading to JSdata2. And we noticed that in the bindOne function you are recomputing computed properties but this is not happening in the bindAll function. So it seems to me that either it is required to recompute them and the bindAll function is wrong, or the bindOne function is running unneccery code. 

let item = _this.get(resourceName, id)
if (item) {
  _this.compute(resourceName, id)
}
jmdobry commented 8 years ago

Probably needs to be added to bindAll.