search

js-dxtools / webpack-validator

Validates your webpack config with Joi
MIT License
295 stars 29 forks source link

Allow new `performance` property in webpack config #149

Closed huy-nguyen closed 7 years ago

huy-nguyen commented 7 years ago

Per the release notes for Webpack's latest beta version, there's a new performance.hints property in the config to enable/disable warnings about bundle size. Currently, using this config property 

module.exports = {
  // other configs
  performance: {
    hints: false
  }
}

causes webpack-validator to error out:

[1] "performance" is not allowed
kentcdodds commented 7 years ago

Feel free to file a pull request, but please note the note in the README.

huy-nguyen commented 7 years ago

Does that mean people won't need webpack-validator after switching to webpack 2?

kentcdodds commented 7 years ago

Correct.

huy-nguyen commented 7 years ago

Closed by #150.