feat: Allow performance.hints in webpack config

huy-nguyen commented 7 years ago

Webpack 2.1.0-beta.28 adds performance.hints (which take boolean values) as a way to enable/disable performance warnings. (The first performance warning is about bundle size.)

kentcdodds commented 7 years ago

CI is logging:

...
src/types/urlPart.js -> dist/types/urlPart.js
module.js:327
    throw err;
    ^
Error: Cannot find module '../../../test/Utils'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (index.test.js:2:1)
    at Module._compile (module.js:409:26)
    at loader (/home/travis/build/js-dxtools/webpack-validator/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/home/travis/build/js-dxtools/webpack-validator/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at /home/travis/build/js-dxtools/webpack-validator/node_modules/mocha/lib/mocha.js:219:27
    at Array.forEach (native)
    at Mocha.loadFiles (/home/travis/build/js-dxtools/webpack-validator/node_modules/mocha/lib/mocha.js:216:14)
    at Mocha.run (/home/travis/build/js-dxtools/webpack-validator/node_modules/mocha/lib/mocha.js:468:10)
    at Object.<anonymous> (/home/travis/build/js-dxtools/webpack-validator/node_modules/mocha/bin/_mocha:403:18)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:139:18)
    at node.js:990:3

We can't merge this until we figure out what's going on here.

huy-nguyen commented 7 years ago

I'll look into it. The validate script ran successfully on my machine so I'm not sure what causes it. I suspect the node version might be a problem. My node is v6.8.1 but the travis build calls for v4. What do you think?

kentcdodds commented 7 years ago

It almost looks like a case sensitivity issue. All filenames should be lower case (in git and the filesystem).

huy-nguyen commented 7 years ago

Yes you were right. It was a case problem and has been fixed.

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #150 into master will not change coverage

@@           master   #150   diff @@
====================================
  Files          18     19     +1   
  Lines         151    153     +2   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
+ Hits          151    153     +2   
  Misses          0      0          
  Partials        0      0

Powered by Codecov. Last update fd3b40d...5df0dd1

kentcdodds commented 7 years ago

Thanks!

js-dxtools / webpack-validator

feat: Allow performance.hints in webpack config #150

Current coverage is 100% (diff: 100%)