js-dxtools / webpack-validator

Validates your webpack config with Joi
MIT License
295 stars 29 forks source link

feat(version): throw error when webpack 2 is installed #157

Closed kentcdodds closed 7 years ago

kentcdodds commented 7 years ago

I think I'll just merge this if the build passes.

Closes #152

BREAKING CHANGE: webpack v2 is not supported and now there will be a message when you're using webpack v2 with webpack-validator.

codecov-io commented 7 years ago

Codecov Report

Merging #157 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #157   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines         153    164   +11     
=====================================
+ Hits          153    164   +11
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c7cc40...f90b2be. Read the comment docs.

kentcdodds commented 7 years ago

I should probably say that my attitude toward this library is very much: "Let's stop maintaining this." I don't want people using this thing anymore. If it doesn't work for someone's use-case then they can fork. Let's all just move on.

kentcdodds commented 7 years ago

I'll go ahead and wait for someone to merge this.

bebraw commented 7 years ago

Yeah. I think the sanest option is to release a final version that's webpack 1 only and state clearly the package has been discontinued since webpack 2 implements the same functionality. I doubt there's a lot of interest in maintaining this package anymore. It would be more worthwhile to improve webpack core validation instead.

kentcdodds commented 7 years ago

Agreed. I'll merge this and a major version will be published which wont work with webpack 2 at all, so people will know. Thanks everyone for working on this! It was a good run :D

jonathanglasmeyer commented 7 years ago

👍🏻 totally agreed.