search

js-dxtools / webpack-validator

Validates your webpack config with Joi
MIT License
295 stars 29 forks source link

Quiet mode #70

Closed bebraw closed 8 years ago

bebraw commented 8 years ago

I added support for quiet mode.

As I had some trouble with npm link, it would be good if you could have a look at the cli side. It should work but better to be safe than sure. It also insisted on rewriting the whole bin file (encoding or file ending problem?).

Closes #69.

codecov-io commented 8 years ago

Current coverage is 100%

Merging #70 into master will not change coverage

@@           master   #70   diff @@
===================================
  Files          15    15          
  Lines          59    60     +1   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits           59    60     +1   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last updated by 2dd7964...3c0c76e

jonathanglasmeyer commented 8 years ago

@nyrosmith could you check that cli works on this branch? I guess that the rewrite could have something to do with newlines on windows vs mac? (@nyrosmith uses windows).

nyrosmith commented 8 years ago

I'll check that ASAPpe I get some time today...

nyrosmith commented 8 years ago

Besides the fact that the CLI doesnot print errors everything else looks good to me.

nyrosmith commented 8 years ago

LGTM! @bebraw Can you squash the commits into one? After that I merge it

bebraw commented 8 years ago

@nyrosmith Squashed to single commit.

nyrosmith commented 8 years ago

Thx @bebraw