search

js-dxtools / webpack-validator

Validates your webpack config with Joi
MIT License
295 stars 29 forks source link

Strict mode - Warn for aliases that match a dependency name #79

Closed bebraw closed 8 years ago

bebraw commented 8 years ago

This should check for resolve.root at least. The point is that we want to avoid a case where webpack picks up something from the project root over node_modules.

Related: https://github.com/reactjs/redux/issues/1681 .

jonathanglasmeyer commented 8 years ago

Implementation approach: the _.intersection of the a) array of folder names in node_modules with the b) flattened array of subfolders under all resolve.root folders should be empty.

jonathanglasmeyer commented 8 years ago

I am on this, using joi 9 .extend and it's awesome. :) will probably pr tomorrow.

jonathanglasmeyer commented 8 years ago

A baseline version of this is implemented in #81.