search

js-dxtools / webpack-validator

Validates your webpack config with Joi
MIT License
295 stars 29 forks source link

output.publicPath validation is too strict #88

Closed bebraw closed 8 years ago

bebraw commented 8 years ago

The following should pass:

output: {
 ...
 publicPath: ''
}

The current check is too strict. We might need Joi.alternative there to allow for empty given it's valid configuration. I use that as a placeholder.

Do you want a PR for this?

jonathanglasmeyer commented 8 years ago

Yep. lets allow empty string. I think my implementation was meant as a best practice but I don't fully remember why it's supposed to be a best practice haha.