search

js-jslog / harpstrata

A library for generating matrix representations of various harmonica layouts played in various positions
0 stars 0 forks source link

Bring pitch and degree matrix determination functions together #17

Open js-jslog opened 4 years ago

js-jslog commented 4 years ago

They essentially have identical logic.

I think making them utilise a higher order function might be over the top, but they should probably be next to one another and produced at the same time with duel inputs.

Another part of this work will be to have the degreematrix determined by a source degree, like the pitchmatrix, rather than from a root offset as it is at the moment. There should then be a layer of fact building which determines the starting degree from the input pozition.

This fact building layer will probably be a useful abstraction for eventually allowing getHarpStrata to potentially accept root pitch rather than harp key.

js-jslog commented 4 years ago

Also look in to this comment https://github.com/js-jslog/harpstrata/pull/14#discussion_r429628515