js-jslog / harpstrata

A library for generating matrix representations of various harmonica layouts played in various positions
0 stars 0 forks source link

Consider reviewing variable naming strategy #25

Open js-jslog opened 4 years ago

js-jslog commented 4 years ago

There are variables using a capitalisation convention as though they are constants but they may not be. Since the removal of the maps in https://github.com/js-jslog/harpstrata/pull/24 I don't really know if we can consider them constants.