Use of <div> vs <span>

[griffinlacek]

This is a pretty small comment, but worth mentioning. You use <span> as a container for your tea headers. This totally works, but a more common usage would be <div>. The reasoning being div is a block element, whereas span is an inline element, which is typically used more commonly inside of other block elements (like spans inside paragraphs). It's not a big deal, but I prefer divs for layout and spans for wrapping code that needs to be different inside another element.

https://github.com/mode-js/tea-cozy/blob/master/index.html#L42-L44

[js-mode]

Great point! I went back and forth on adding a class to the . For some reason I usually add class tags to

and leave the without a class at all. I added the class tag (even though I have the CSS rule that could target all of the elements; just to show versatility and that I can add classes to

or . Going forward I will make sure to keep this consistent.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.