search

js-republic / sideral

:construction: #OSS
GNU General Public License v3.0
3 stars 3 forks source link

An in-range update of redux is breaking the build 🚨 #72

Open greenkeeper[bot] opened 7 years ago

greenkeeper[bot] commented 7 years ago

Version 3.7.0 of redux just got published.

Branch Build failing 🚨
Dependency redux
Current Version 3.6.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

redux is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them. I recommend you give this issue a very high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/js-republic/sideral/builds/243895656?utm_source=github_status&utm_medium=notification)
Release Notes v3.7.0

Another long break!

Oh, hey! I didn't see you sitting there. You look bored. How about a Redux release to spice things up?

Not a huge set of changes to report here. The biggest change, and the reason for the minor bump, is the UMD build is now done via Rollup. One big advantage is more readable code in the bundle. Rollup does "scope hoisting", which is a fancy term for putting every module at the top level of the file. Other than a surrounding IIFE, all of the code in Redux all lives together. You can compare the two here:

Rollup UMD build
vs
Webpack UMD build

There is also a cost savings of 30,811 vs 26,880 bytes, and 6,999 vs 5,995 bytes minified. Redux is already a small library, and this helps shave some extra bytes for our UMD users.

One thing to note is that Webpack has introduced it's own scope hoisting feature in 3.0 beta. So, this isn't intended as an indictment of Webpack. You should continue to use it in your own apps. The adage of "Webpack is for apps, Rollup is for libraries" definitely holds true. It still has a superior developer experience with hot module reloading and webpack-dev-server. But use whatever makes sense for your project, not just whatever we use. 😄

We're also looking at applying this to the NPM bundle. The main motivation is again more readable code in your bundles. Instead of transpilation oddities from Babel, you will end up with a single clean file, which should be easier to read through and debug. It's currently scheduled for the big, mythical 4.0 release and you can follow along in #2358

Changes

Commits

The new version differs by 309 commits.

  • 2d229f0 3.7.0
  • f3bba96 Removing the browser field for now
  • f4d9e55 Upgrade all example deps, including the universal example to Webpack 2
  • 2bc8f84 Upgrade some other deps
  • 070b838 Upgrades and remove check-es3-syntax since Rollup breaks it always
  • 1094724 Fix a typo in the Immutable.js docs (#2453)
  • bf3a557 Fix redux-mock-store libdef for todos-flow (#2430)
  • bf2b9b5 give redux-subscriber some attention in StoreSetup.md (#2433)
  • 8b3e0cb syncing docs with recent PR (2431) (#2432)
  • e238a19 'todo' const removal from reducers/todos.js (#2431)
  • 0babfab Merge pull request #2429 from alexbaumgertner/bugfix/doc-link
  • ae563c3 Fix link to ImmutableData article
  • 383215a Update redux.js (#2428)
  • c9ad6a4 Add 100% test coverage for todos-flow example (#2413)
  • ea16d76 Fix eslint warnings, update react-scripts (#2420)

There are 250 commits in total.

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 3.6.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 7 years ago

Version 3.7.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Release Notes v3.7.1

This reverts the console.error on bindActionCreators() coming from #2279.

While well-intentioned, when star importing all exports from a module (import * as actions from './actions'), transpilation by Babel defaults to adding a default and __esModule property to the import, which are not functions. While it can be disabled, this isn't common to do and leads to a lot of confusion. So, we're reverting the change.

Thanks for the feedback from everyone and the civility and healthy discourse on the issue!

Commits

The new version differs by 10 commits.

  • 6eed34d Switch prepublish to prepare script for npm 5 warning
  • 7fbddd6 3.7.1
  • 2bdcf66 Revert "Add warning when bindActionCreators encounters non-function property (#2279)" (#2473)
  • 6c7fe8e Merge pull request #2472 from jimmyhmiller/fix-dot
  • cb493d5 Merge pull request #2471 from BeLi4L/patch-1
  • ec5b9c7 removed extra dot
  • c5bfb97 docs: fix wrong parameters
  • 9e5feb2 Moved propTypes checking, fixed undefined error (#2464)
  • 689c800 Merge pull request #2463 from taehwanno/docs-change-array-reduce
  • 4155297 Change Array.reduce to Array.prototype.reduce

See the full diff