search

js6pak / mojangfix

Minecraft b1.7.3 mod that fixes skins, authentication and more
https://modrinth.com/mod/mojangfix
GNU Lesser General Public License v3.0
17 stars 7 forks source link

Make skin fix fetch skin from Mojang API instead of 3rd party service #10

Open forkiesassds opened 1 year ago

forkiesassds commented 1 year ago

Avoids issues where skins can be cached for an extended period of time, along side potentially fixing false positive where Steve skins are flagged as Alex skins

js6pak commented 1 year ago

MojangFix can already use the mojang api (https://github.com/js6pak/mojangfix/blob/master/src/main/java/pl/js6pak/mojangfix/client/skinfix/provider/MojangProfileProvider.java) but it only does so as a last resort because it has a much stricter rate limit and requires 2 requests (name -> uuid and uuid -> skin)

telvarost commented 7 months ago

Added a config to change priority to Mojang over AshCon (default false) if you prefer to get the skin from Mojang. https://github.com/telvarost/MojangFix-StationAPI

Open to discussion on this. Once again feel free to contact me if there are any issues with this comment or the fork. Trying to provide a variant with all the configs that users would like (so even more forks don't get created). Thanks!

telvarost commented 7 months ago

Using jankson I was able to create a version of the mod that doesn't use StationAPI and GCAPI if you are interested in the changes being part of the main mod just let me know and we can upstream them 👍