jsGanttImproved / ng-gantt

Gantt for Angular 8 based on jsgantt-improved
MIT License
61 stars 28 forks source link

Internationalisation at jsGanttImproved/ng-gantt #11

Closed yeheshuah closed 5 years ago

yeheshuah commented 5 years ago

Does internationalisation works at jsGanttImproved/ng-gantt.

According to the internationalisation specification it looks like there is internationalisation functionality, but how to use it?

Thanks in advance.


Angular CLI: 7.3.8 Node: 10.15.3 OS: win32 x64 Angular: 7.2.13

jsgantt-improved: ^2.2.11 ng-gantt: ^2.1.0

mariohmol commented 5 years ago

does it works for u?

https://github.com/jsGanttImproved/ng-gantt/blob/master/src/app/demo/demo.component.ts#L146

yeheshuah commented 5 years ago

does it works for u?

https://github.com/jsGanttImproved/ng-gantt/blob/master/src/app/demo/demo.component.ts#L146

Nope...

demo.component.ts#L146 is just setting up current language, isn't it? Otherwise, what language should be used. But, how to set up language content like here at comented out code.

mariohmol commented 5 years ago

check this line... https://github.com/jsGanttImproved/ng-gantt/blob/edf3d23eac0d9edf707650b97a9ec9e8bc1ddf0a/src/app/demo/demo.component.html#L4

basically.. you can put in on options this.editorOptions = { vLang: 'en' }

yeheshuah commented 5 years ago

check this line... https://github.com/jsGanttImproved/ng-gantt/blob/edf3d23eac0d9edf707650b97a9ec9e8bc1ddf0a/src/app/demo/demo.component.html#L4

basically.. you can put in on options this.editorOptions = { vLang: 'en' }

For example, I want to add Japanese localisation. Yes, I can setup this.editorOptions = { vLang: 'ja' }, but how can I setup key-values listed in Internationalisation documentation?

mariohmol commented 5 years ago

gotcha.. we need a ja translation...

see this file

https://github.com/jsGanttImproved/jsgantt-improved/blob/master/src/lang.ts

can u make a translation for your language for us?

yeheshuah commented 5 years ago

gotcha.. we need a ja translation...

see this file

https://github.com/jsGanttImproved/jsgantt-improved/blob/master/src/lang.ts

Great!

can u make a translation for your language for us?

Yes, I can. When I make a translation, I will create pull request.

mariohmol commented 5 years ago

@yeheshuah make for us =)

mariohmol commented 5 years ago

Closing this issue and putting in jgantt-improved

https://github.com/jsGanttImproved/jsgantt-improved/issues/241

mariohmol commented 5 years ago

released on new version thanks to @yeheshuah

luk3skyw4lker commented 4 years ago

Does it have support for pt-BR language? I can't use addLang to add it to the language options.

luk3skyw4lker commented 4 years ago

Found it already, thanks!