search

jsaglio42 / GBmu

4 stars 1 forks source link

MBC5 Crash #40

Open Ngoguey42 opened 8 years ago

Ngoguey42 commented 8 years ago

Crash when accessing the fly menu in pokemon blue/red

image

Pokemon_Rouge (12).ss.txt

jsaglio42 commented 8 years ago

The gb doc is not clear about what to do if an invalid number is given. This is a recurrent issue (eg should crash if something is written to RAM but not enabled). Possible fix: remove assert and only keep interesting bits, eg if bankRam is encoded with mask 0x7F, remove assert (v & ~~0x7F == 0) and simply set bankRam to (v & 0x7F). /!\ to data corruption, removing assert would allow illegal operation