Closed omarjcamanto closed 1 year ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
0ceb844
) 80.06% compared to head (dd3e462
) 80.06%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@omarjcamanto: Out of curiosity, before I merge this, can you run devtools::check() to see if it's happy with the way this has been handled?Sometimes it will complain about the examples, so hopefully it comes back clean [or at least with unrelated issues].
I have run devtools::check()
and it returned some notes that appear to be unrelated to the changes made in esHelpers.R
.
I can try to resolve those devtools::check()
notes if needed!
Interesting. Some of those notes are new/surprising (e.g., it complaining about a license). Will circle back to this, but for now will merge.
85
esHelpers.R appeared to have exported functionality but did not have a
@returns
value. And so, I added a@returns
and, just in case, a@examples
tag to the esHelpers.R documentation.Lastly, I can confirm that all internal, non-exported functions have
@nord
tags.