jsakaluk / dySEM

dySEM
https://jsakaluk.github.io/dySEM/
GNU General Public License v3.0
6 stars 4 forks source link

docs: fixed esHelpers.R roxygen documentation. #87

Closed omarjcamanto closed 1 year ago

omarjcamanto commented 1 year ago

85

esHelpers.R appeared to have exported functionality but did not have a @returns value. And so, I added a @returns and, just in case, a @examples tag to the esHelpers.R documentation.

Lastly, I can confirm that all internal, non-exported functions have @nord tags.

codecov-commenter commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (0ceb844) 80.06% compared to head (dd3e462) 80.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #87 +/- ## ======================================= Coverage 80.06% 80.06% ======================================= Files 20 20 Lines 3697 3697 ======================================= Hits 2960 2960 Misses 737 737 ``` | [Files](https://app.codecov.io/gh/jsakaluk/dySEM/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+Sakaluk) | Coverage Δ | | |---|---|---| | [R/esHelpers.R](https://app.codecov.io/gh/jsakaluk/dySEM/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=John+Sakaluk#diff-Ui9lc0hlbHBlcnMuUg==) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsakaluk commented 1 year ago

@omarjcamanto: Out of curiosity, before I merge this, can you run devtools::check() to see if it's happy with the way this has been handled?Sometimes it will complain about the examples, so hopefully it comes back clean [or at least with unrelated issues].

omarjcamanto commented 1 year ago

I have run devtools::check() and it returned some notes that appear to be unrelated to the changes made in esHelpers.R.

Screenshot 2023-10-16 at 3 32 05 PM

I can try to resolve those devtools::check() notes if needed!

jsakaluk commented 1 year ago

Interesting. Some of those notes are new/surprising (e.g., it complaining about a license). Will circle back to this, but for now will merge.