Closed WimVdSElia closed 3 months ago
This is a biggy. Good work @WimVdSElia. Seems like you need to update your MS packages.
@jsakamoto what are your toughts on this impl?
Updated the Ms Package + the pr text
I apologize for the long delay, but I returned to the "Blazing Story" project! And @WimVdSElia, thank you for your contributions!
Unfortunately, I don't want to say this, but I couldn't accept this pull request directly😥. However, the reasons for that are not intrinsic. It is my preference for coding style. The changes I could not accept are below:
I respect your preference for coding style and agree that the style above may be much better than mine. However, this is my hobby work, and I don't want to spend my time arguing and discussing which coding style we should use. I'd appreciate your understanding.
Anyway, the essential changes in your pull request will be helpful and acceptable to me. But could you please make a small pull request for each feature instead of one big one, including various changes? And I'd appreciate it keeping the coding style.
I hope you understand my point and keep contributing. And thanks, @Zettersten, for your escort!
By the way, hey @WimVdSElia, I'm looking forward to seeing your lovely account icon in the "Contributors" list. My little son said your account icon is funny😊 and very nice!👍
Changes
v.1.0.0-preview.38
Extra
Text Options
RenderFragment
Some examples:
Themable
Add a script to your story project like
extraFunction.js
the method must bethemableCanvasFrame
Then add to
iframe.html
Last change the
App.razor