search

jsakamoto / Toolbelt.Blazor.HotKeys2

This is a class library that provides configuration-centric keyboard shortcuts for your Blazor apps.
https://jsakamoto.github.io/Toolbelt.Blazor.HotKeys2/
Mozilla Public License 2.0
102 stars 7 forks source link

finer excludes with css selector #12

Closed jhony1104 closed 1 year ago

jhony1104 commented 1 year ago

Using this library, I had problems excluding very specific inputs.

This PR is aimed to provide finer exclude control by providing the option ot use a CSS selector to exclude fields.

jsakamoto commented 1 year ago

@jhony1104 Thank you for the pull request! Actually, I have been aware of the need to exclude by the query selector. So this feature must be useful widely.

Unluckily, this is a public library, so it is really important to keep compatibility with previous versions. If somebody updates the uses of this library's version from the current release to the one that merged your pull request, they must cause a build error. Therefore, I can not publish a new version of this library that merged your pull request immediately because it will break the compatibility with previous versions. I'll change the method signature before releasing a new version of this library to keep the compatibility. Thank you for being so understanding.

Anyway, your contributions are really great!👍 Please look forward to releasing the new version of this library, which includes your pull request.