jsakamoto / ipaddressrange

.NET Class Library for range of IP address, both IPv4 and IPv6.
Mozilla Public License 2.0
370 stars 71 forks source link

Parse / TryParse #5

Closed M-Zuber closed 9 years ago

M-Zuber commented 9 years ago

The addition of such functionality would add a lot to this package

M-Zuber commented 9 years ago

I hope to have a PR ready soon

jsakamoto commented 9 years ago

Thank you for your pull request #6 :)

I think, adding TryParse static method is a good idea. But adding Parse static method would cause confusing among the library users, dosen't it?

"What difference does new IPAddressRange(...) and IPAddressRange.Parse(...)?"

Could you tell me your opinion about needs of Parse method?

M-Zuber commented 9 years ago

The reason I feel to add a Parse method is more due to convention. I see it is being the second half of a pair together with TryParse. I have no problem removing it though.

jsakamoto commented 9 years ago

Thank you for your reply.

I see it is being the second half of a pair together with TryParse.

I'll drink to that.

Well, I would like to consider well to obsoloete public constructor instead of adding Parse static method. (That means I'll conceal the constructor to private access control.)

Please give me some time to work :)

M-Zuber commented 9 years ago

:+1: Take you time

jsakamoto commented 9 years ago

Thank you for waiting.

I merged it and publish new package v.1.2!
http://www.nuget.org/packages/IPAddressRange/

Thank you for your suggestion. :smile:

M-Zuber commented 9 years ago

Pleasure!