search

jsakamoto / ipaddressrange

.NET Class Library for range of IP address, both IPv4 and IPv6.
Mozilla Public License 2.0
370 stars 71 forks source link

Update to net6.0 #75

Closed danspam closed 2 years ago

danspam commented 2 years ago

Updated to .net6.0 and added namespaces to unit tests

jsakamoto commented 2 years ago

Thank you for your contributions! Yeah, that must be a good idea to upgrade the version of .NET used to unit test projects to 6.

However, in my opinion, we have to guarantee this package works fine even on .NET Core 3.1 and .NET Framework 4.6.2 via unit tests because those runtimes are still in support terms.

Therefore, droping the "netcoreapp3.1" and "net45" TFM form the "IPAddressRange.Test/IPAddressRange.Test.csproj" is not good idea.

https://github.com/jsakamoto/ipaddressrange/pull/75/files#diff-bd70ce01c721dc8d116ef4180ab8d448daab85b593c0e3619a0641bb6af8d579L4

Could you consider making the "IPAddressRange.Test.csproj" to support not only .NET 6 but also .NET Core 3.1 and .NET Framework 4.6.2 like this?

<TargetFrameworks>netcoreapp3.1;net462;net6</TargetFrameworks>

And, I cannot accept your changes to the "IPAddressRange" library to drop support for .NET Framework 4.6.2 and .NET Core 3.1 for the same reason above.

The current version of "IPAddressRange" works fine even though on .NET6 and .NET 7 Preview. Currently, it doesn't have any problem. Therefore, your pull request to drop those lower compatibility has nothing worth it. That means this pull request will lose valuable of this library.

I'm very sorry, but I have to reject your pull request.

Instead, I'll wait for your new pull request about improving the unit test project to cover the .NET version 6.

Thank you for being so understanding!