search

jsanahuja / InstagramFeed

Vanilla JavaScript Instagram Feed without access token. Not using the Instagram API
MIT License
318 stars 128 forks source link

Possible to display captions? #14

Closed Matra-Simca closed 4 years ago

Matra-Simca commented 4 years ago

Hi - this is brilliant, is it possible to have an option to display captions?

jsanahuja commented 4 years ago

Hello, there is no such option for now but might implement it in the future or accept a pull request implementing it.

N-Shar-ma commented 4 years ago

Hello, I'd like to fix this issue and was thinking of adding a display_captions option for showing the caption as an overlay when hovering over the image, so that the grid layout is not disturbed. The following pen is a demo: https://codepen.io/N-Sharma/pen/BazPyNG?editors=1100

If you are fine with this implementation, I will open a PR for this

jsanahuja commented 4 years ago

Sure, send the PR. The only change I would do is removing top:0 and adding max-height:100%

Thanks!