jsantell / node-cfx

programmatically use cfx with node.js
MIT License
4 stars 1 forks source link

add deprecation notices #10

Open PixnBits opened 9 years ago

PixnBits commented 9 years ago

I created a deprecation branch (diff) as a proposal for the changes (first time being on a project w/ multiple contributers on github).

Should we also add messages when ran by users? (e.g. console.warn(...);?)

PixnBits commented 9 years ago

thoughts, @peacememories ?

peacememories commented 9 years ago

Got no real opinion on this. Maybe add the prospective release date for Firefox supporting jpi? On 8 Mar 2015 22:44, "Nick Oliver" notifications@github.com wrote:

thoughts, @peacememories https://github.com/peacememories ?

— Reply to this email directly or view it on GitHub https://github.com/jsantell/node-cfx/issues/10#issuecomment-77776353.

peacememories commented 9 years ago

As for the console.warn, I'd add that when firefox 38 actually comes out and makes cfx obsolete. Right now it would send a weird message. "This is the tool you need to develop addons for the current Firefox, but it's deprecated"

PixnBits commented 9 years ago

FWIW FF38 looks to be May 12th