search

jsantell / node-cfx

programmatically use cfx with node.js
MIT License
4 stars 1 forks source link

require('cfx') changes working directory #3

Closed peacememories closed 9 years ago

peacememories commented 9 years ago

What it says in the title. Unexpected behaviour that I don't think should happen, but at least needs to be documented.

peacememories commented 9 years ago

Deleting the cwd call doesn't seem to have any negative consequences. Why is it there?

jsantell commented 9 years ago

We're currently deprecating cfx in favor of jpm (blog post) -- I just gave you repo access to node-cfx though so you're not held up by me :) merge away!

peacememories commented 9 years ago

Yeah I know, but until the current firefox release supports it I guess I'm stuck with cfx^^. Thanks for the access, though I do hope I'm not ruining a perfectly good codebase. Not a seasoned foss contributor here.

jsantell commented 9 years ago

FWIW, I don't think many people other than myself previously were using this, and @PixnBits was just recently working on it for gulp-cfx-xpi -- I'll give them access as well

jsantell commented 9 years ago

@PixnBits @peacememories let me know your npm names if you want publish access as well

PixnBits commented 9 years ago

related to PR #6