jsarafajr / slackify-markdown

Convert markdown into Slack-specific markdown
MIT License
129 stars 25 forks source link

[Snyk] Security upgrade remark-parse from 8.0.3 to 9.0.0 #16

Closed snyk-bot closed 3 years ago

snyk-bot commented 3 years ago

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 661/1000
Why? Recently disclosed, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-TRIM-1017038
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information: 🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

72636c commented 3 years ago

Hi @jsarafajr, could we get a new patch version released with this change? 🙏

jsarafajr commented 3 years ago

hi @72636c, looks like remark-parse@9 is not fully compatible with remark-stringify@8 which this library uses as well and some of the tests are failing. As for now, master is broken, I'll take a look into it. Filled an issue for now https://github.com/jsarafajr/slackify-markdown/issues/18