search

jsarafajr / slackify-markdown

Convert markdown into Slack-specific markdown
MIT License
129 stars 25 forks source link

Breaking change from 3.1.0 to 4.0.0 #25

Closed ahermant closed 3 years ago

ahermant commented 3 years ago

Hi there, I am working on semantic-release-slack-bot which uses slackify-markdown as a dependency. I would like to bump slackify-markdown from 3.1.0 to 4.3.0 to mitigate a vulnerability in trim< 0.0.3 but I cannot figure what is the breaking change between slackify-markdown 3.1.0 and slackify-markdown 4.0.0 I can only see some dependencies and internal changes. All my tests are passing. Did I miss something ?

jsarafajr commented 3 years ago

Hi @ahermant, in v4 the internal mechanism was rewritten as we switched to a new Remark plugin. I think there shouldn't be breaking changes for the clients of this library. But since we did such a major internal change we made it to be a major version bump.

ahermant commented 3 years ago

Perfect, thank you very much for your answer.