search

jsarafajr / slackify-markdown

Convert markdown into Slack-specific markdown
MIT License
129 stars 25 forks source link

Check for already encoded URIs #27

Closed jmeischner closed 2 years ago

jmeischner commented 2 years ago

I had the problem that I added a Link with a query parameter which was already url encoded. That's why I added the check before the encodeURI call if the node.url was already encoded.

jmeischner commented 2 years ago

Solution was taken from here: stackoverflow

jsarafajr commented 2 years ago

Hey, thanks for contributing, looks good 👍

Would you mind fixing the lint issues, looks like the build is failing.

codecov-commenter commented 2 years ago

Codecov Report

Merging #27 (e9c74c3) into master (d912761) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           99       101    +2     
  Branches        15        17    +2     
=========================================
+ Hits            99       101    +2
Impacted Files Coverage Δ
src/slackify.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d912761...e9c74c3. Read the comment docs.

jmeischner commented 2 years ago

@jsarafajr Done ✅😊