Fix: Remove empty html comments

jsarafajr / slackify-markdown

Convert markdown into Slack-specific markdown

MIT License

129 stars 25 forks source link

Fix: Remove empty html comments #37

Open hassan-pullflow opened 1 year ago

hassan-pullflow commented 1 year ago

added regex to remove empty html comments added after markdown.

jsarafajr commented 1 year ago

Hey, thanks for the contribution. Would you mind adding a test for it?

hassan-pullflow commented 1 year ago

Hi @jsarafajr, I have added test coverage. We were getting error for one particular case where markdown was added extra html comments. Here is example of that case: Screenshot from 2023-02-28 16-40-36

jsarafajr commented 1 year ago

Sorry for the silence, I'm trying to think of a more elegant solution that would not involve a regexp as it doesn't fit well with the original approach of parsing content into tree and working with each node separately. Maybe remark/unified has something out of the box...