search

jsayol / vscode-firebase-explorer

Visual Studio Code extension to explore and manage your Firebase projects
https://devlibrary.withgoogle.com/products/firebase/repos/jsayol-vscode-firebase-explorer
MIT License
149 stars 22 forks source link

Current master branch cannot log in #11

Closed richarddavenport closed 5 years ago

richarddavenport commented 5 years ago

Hey @jsayol love the extension. I forked it to start working on adding some additional functionality, namely storage related tasks. However, when I run the current master branch it throws an error:

Screenshot from 2019-07-31 22-20-44

I traced it to here, called from here. Looks like some of your last refactors aren't quite done maybe?

When I check out tag 0.3.3 it all works as expected.

I'd really like to try and make some enhancements to your already awesome extension! Just not sure how to fix the current state of the code. Could you help me fix it?

richarddavenport commented 5 years ago

~~Should have done some more investigating. I see that you have "migration" code when the extension updates. I realized I needed to run this block. Just curious if you'd be willing to have some contributing guidelines or help added to the repo, now that I've discovered my issue? Also, I'd be curious what your proposed solution for this issue moving forward is? If I install an older version, say 0.1, and I run the latest code, non of the migration code runs. This is an issue others would run into if they would want to contribute as well. Do you have any ideas? Thanks!~~

Okay, so ultimately my problem is that I was debugging while having a version installed. I had to completely uninstall and deleted the extension folder. When you develop do you not have the extension installed?

richarddavenport commented 5 years ago

Gonna close, since this is just an issue with development and not the extension itself.