search

jsayol / vscode-firebase-explorer

Visual Studio Code extension to explore and manage your Firebase projects
https://devlibrary.withgoogle.com/products/firebase/repos/jsayol-vscode-firebase-explorer
MIT License
149 stars 22 forks source link

FR: Alphabetize the project list #3

Closed samtstern closed 5 years ago

samtstern commented 5 years ago

I have like a million Firebase projects so I see this: image

The order seems to be a bit random, would be good if they were alphabetized!

jsayol commented 5 years ago

Good idea! I'll change that.

Something else I noticed in your screenshot, there should be icons next to the account email and the project names. Are all the icons missing for you elsewhere too? It should look like the screenshot in the README.

samtstern commented 5 years ago

Yeah I noticed the same. None of the icons are there for me ... I am on Google's Linux distro though (a Debian fork) so I don't know if the system has good emoji fonts or whatever it might be using.

jsayol commented 5 years ago

All the icons are SVGs distributed with the extension itself, and I'm also on Linux. That's strange, I'll look into it. What version of VSCode are you running?

samtstern commented 5 years ago

Version: 1.30.0 Commit: c6e592b2b5770e40a98cb9c2715a8ef89aec3d74 Date: 2018-12-11T22:21:33.585Z Electron: 2.0.12 Chrome: 61.0.3163.100 Node.js: 8.9.3 V8: 6.1.534.41 OS: Linux x64 4.17.0-3rodete2-amd64

On Wed, Dec 19, 2018 at 1:44 PM Josep Sayol notifications@github.com wrote:

All the icons are SVGs distributed with the extension itself, and I'm also on Linux. That's strange, I'll look into it. What version of VSCode are you running?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jsayol/vscode-firebase-explorer/issues/3#issuecomment-448754490, or mute the thread https://github.com/notifications/unsubscribe-auth/AIEw6qDMBQR2JtHi2PsuukwsQxKCsaKtks5u6rM6gaJpZM4ZbEEP .

jsayol commented 5 years ago

Hey @samtstern, I just published a new version. The projects should now show in alphabetic order (ignoring case).

I also added proper XML headers to many of the SVG files that were missing them, let's see if that fixes it. I'm running the exact same version of VSCode as you so... strange. If this doesn't fix it let me know and I'll keep investigating.

samtstern commented 5 years ago

I've got alphabetized projects (:smile:) but no icons (:cry:). Any logs I can pass on?

jsayol commented 5 years ago

Could you open the dev tools (Help -> Toggle Developer Tools) and see if there's any relevant error messages in the console?

samtstern commented 5 years ago

There are a lot of Failed to load resource: net::ERR_FILE_NOT_FOUND and the paths look like this:

/usr/local/google/home/samstern/Projects/firebase/myproject/assets/valuetype/boolean.svg

So looks like it's looking for the SVGs inside my project, rather than inside your plugin.

jsayol commented 5 years ago

That was super helpful! I was definitely not loading the icons correctly. I just published a new version, this one should fix it for sure :crossed_fingers:

Every time I tested the extension I had the extension project itself open in VSCode, which is why I could always see the icons but apparently no one else could :man_facepalming:

samtstern commented 5 years ago

@jsayol woohooo! Icons worked now.

jsayol commented 5 years ago

Awesome! Thanks for your help figuring this out :-)