jsb / Gatherer

Vanilla World of Warcraft (v.1.12.1) AddOn
31 stars 17 forks source link

gatherer_p2p 1.0.0, with periodic random nodes broadcasting #3

Closed theoden-dd closed 7 years ago

theoden-dd commented 7 years ago

Hello, jsb

Thanks for great addon patch, that inspired me to extend its idea further.

I propose three things at a time:

  1. New feature of broadcasting random node every 10 seconds. The timeout could easily be adjusted later.
  2. New versioning, almost fully compliant to the semantic one.

    The problem I'm trying to solve is confusing prefix 2.99. It is used in the original Gatherer both for the latest vanilla versions and for later BC versions.

    To keep things simple I suggest: 2.1. Nail major version to "1" to be in sync with the client. 2.2. Every tenth minor version break message format compatibility. E.g. 1.0.x and 1.9.x are compatible, 1.0.x and 1.10.x are not. Yes, it's the single tricky thing here. 2.3. Patch component is used for bugfixes, as usual.

    To avoid clashing with older Gatherer 1.x versions we could change name to the "gatherer_p2p" for example.

  3. New development process compliant to the git flow. Single master branch for all needs tends to make development messy.

Thanks in advance for any feedback on this proposal.

NB: I have already got an idea how to improve this dumb algorithm.

jsb commented 7 years ago

Great work! This looks like one of the ideas I had in mind for peer-to-peer broadcasting of already known nodes. Let me check it out and give it a try.

theoden-dd commented 7 years ago

Pleased by your appraisal. It motivates to work further, thank you.