jscad / OpenJSCAD.org

JSCAD is an open source set of modular, browser and command line tools for creating parametric 2D and 3D designs with JavaScript code. It provides a quick, precise and reproducible method for generating 3D models, and is especially useful for 3D printing applications.
https://openjscad.xyz/
MIT License
2.66k stars 515 forks source link

OpenJSCAD stl generation error not present in openscad. #115

Closed juergenboehm closed 7 years ago

juergenboehm commented 8 years ago

If one transforms the scad file

http://www.aviduratas.de/modelpart-025.scad

with openJSCAD one gets

http://www.aviduratas.de/openjscad.stl

transformed with openscad one gets

http://www.aviduratas.de/modelpart-025.stl

A review with netfabb shows, that modelpart-025.stl is correct (only "expected holes", where two polyhedra are connected by a single edge only).

But openjscad.stl contains severe errors, especially the following, where a triangle is inserted, that does not appear in the original .scad file:

http://www.aviduratas.de/openjscad-error.png

juergenboehm commented 8 years ago

As I rearranged files on my homepage now the urls are

http://www.aviduratas.de/openjscad/modelpart-025.scad

and so on for the other files

z3dev commented 8 years ago

Pull request #107 contains some changes to CSG.js and openjscad.js. I ran some tests and all issues with T-junctions were resolved after making those changes.

If you need this fixed then please make the changes manually.

z3dev commented 7 years ago

This issue was moved to jscad/io#14