feat(modeling): rework poly3 functions and tests to use vertices - Githubissues

jscad / OpenJSCAD.org

JSCAD is an open source set of modular, browser and command line tools for creating parametric 2D and 3D designs with JavaScript code. It provides a quick, precise and reproducible method for generating 3D models, and is especially useful for 3D printing applications.

https://openjscad.xyz/

MIT License

2.58k stars 505 forks source link

feat(modeling): rework poly3 functions and tests to use vertices #1244

Closed z3dev closed 1 year ago

z3dev commented 1 year ago

These changes rename several functions of poly3:

fromPointsAndPlane ==> fromVerticesAndPlane
toPoints ==> toVertices

This aligns with the new standards for 2D points versus 3D vertices.

The other changes are refactoring of code in modeling and io packages to use the new names.

FYI, there will be another PR for poly2, and other geometry. ;)

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Does your submission pass tests?