Closed z3dev closed 1 year ago
@platypii What do you think about removing support for V1 and V2 geometries, and just support V3 geometries? This goes the same for the demos.
@platypii @hrgdavor thanks for the reviews and assistance.
there have been more improvements to the regl-renderer, which seems 100% functional again.
i have no idea if this will be used in the new V3 web UI but someone may be interested in using package.
Can you do the review again? Thanks
@z3dev how can I test this?
Opening demo.html
and demo.es.html
in the browser as a file doesn't work, it needs to be hosted.
I tried going into packages/utils/regl-renderer
and doing npm run demo-cli
and got an error about missing package gl
.
npm i gl
didn't work because Unsupported URL Type "workspace:": workspace:2.1.4
.
I figured I would try switching to pnpm
, which seems like it helped. I was able to run pnpm i gl
. But pnpm run demo-cli
gives me error:
node: symbol lookup error: /home/platypii/code/jscad/node_modules/.pnpm/gl@6.0.2/node_modules/gl/build/Release/webgl.node: undefined symbol: _Z15XextFindDisplayP15_XExtensionInfoP9_XDisplay
When I try to run pnpm run dev
I get error:
sh: 1: budo: not found
An update to the README would be helpful?
@z3dev how can I test this?
Opening
demo.html
anddemo.es.html
in the browser as a file doesn't work, it needs to be hosted.
Correct. We are at the mercy of the browsers as CORS has a huge affect on 'import'. So, a small server is required. I was running the python built in server.
Do you think we should install the little server for NPM as part of 'dev'?
I tried going into
packages/utils/regl-renderer
and doingnpm run demo-cli
and got an error about missing packagegl
.
npm i gl
didn't work becauseUnsupported URL Type "workspace:": workspace:2.1.4
.I figured I would try switching to
pnpm
, which seems like it helped. I was able to runpnpm i gl
. Butpnpm run demo-cli
gives me error:
pnpm is correct.
node: symbol lookup error: /home/platypii/code/jscad/node_modules/.pnpm/gl@6.0.2/node_modules/gl/build/Release/webgl.node: undefined symbol: _Z15XextFindDisplayP15_XExtensionInfoP9_XDisplay
can't help here... looks like the install of GL didn't work. Maybe you need more compilers, etc.
When I try to run
pnpm run dev
I get error:sh: 1: budo: not found
budo is common js only. It kind of sucked anyway. I'll replace with something useful
An update to the README would be helpful?
OK. Will try to find a few common solutions,and update the documents.
esbuild
aside from building can also run in mode that serves html and built code.
npx http-server
works for serving local files pretty easily. When I do that, the page loads, but I get error loading http://localhost:8080/jscad-modeling.es.js
npx http-server
works for serving local files pretty easily. When I do that, the page loads, but I get error loadinghttp://localhost:8080/jscad-modeling.es.js
This will be corrected once V3 packages are published, but for now a local copy of the modeling package is required.
These changes complete the bundling of regl-renderer using rollup. There were some adjustments to the imports and exports to get the package into a usable state. Also, a new demo (HTML) was added to demonstrate how to use V3 modeling and regl-renderer together.
A new section for V3 geometry to regl entities was created, as well as tests.
All Submissions: