Closed platypii closed 10 months ago
nice work !
@platypii did you sleep the last few weeks?
i'm not really interested in reviewing 697 files. UGG
is there anything specific that you would like reviewed?
@platypii did you sleep the last few weeks?
i'm not really interested in reviewing 697 files. UGG
is there anything specific that you would like reviewed?
Sorry. I can try to split it up into multiple PRs if you prefer? Basically it's all just syntax changes on the types. Most of if was search-and-replace across all files. I tried to be pretty careful. So, if you want to approve, I'm happy to fix any bugs that come up in the future.
This PR updates V3 branch to fix a ton of type errors. Also a bunch of jsdoc cleanup. Typescript uses jsdoc for type hints, so they are related.
Changes include:
import type ... from './type.d.ts'
filesimport { Geom2 }
toimport type { Geom2 }
. Why? Because modern typescript requires adding "type" in order to stay compatible with ES modules.Geom2
,Geom3
,Poly3
, etc when used as a typeNumber
,Float
,Integer
tonumber
String
tostring
Note: this doesn't fix all the type errors, that's a bigger project. But this helps fix a lot of them. My goal is to have good autocomplete for JSCAD, and having good types really helps with that.
Sorry for the huge PR!
All Submissions: