jscad / OpenJSCAD.org

JSCAD is an open source set of modular, browser and command line tools for creating parametric 2D and 3D designs with JavaScript code. It provides a quick, precise and reproducible method for generating 3D models, and is especially useful for 3D printing applications.
https://openjscad.xyz/
MIT License
2.58k stars 505 forks source link

fix(modeling): use modern typescript imports #1274

Closed platypii closed 10 months ago

platypii commented 11 months ago

This PR updates V3 branch to fix a ton of type errors. Also a bunch of jsdoc cleanup. Typescript uses jsdoc for type hints, so they are related.

Changes include:

Note: this doesn't fix all the type errors, that's a bigger project. But this helps fix a lot of them. My goal is to have good autocomplete for JSCAD, and having good types really helps with that.

Sorry for the huge PR!

All Submissions:

hrgdavor commented 11 months ago

nice work !

z3dev commented 11 months ago

@platypii did you sleep the last few weeks?

i'm not really interested in reviewing 697 files. UGG

is there anything specific that you would like reviewed?

platypii commented 11 months ago

@platypii did you sleep the last few weeks?

i'm not really interested in reviewing 697 files. UGG

is there anything specific that you would like reviewed?

Sorry. I can try to split it up into multiple PRs if you prefer? Basically it's all just syntax changes on the types. Most of if was search-and-replace across all files. I tried to be pretty careful. So, if you want to approve, I'm happy to fix any bugs that come up in the future.