JSCAD is an open source set of modular, browser and command line tools for creating parametric 2D and 3D designs with JavaScript code. It provides a quick, precise and reproducible method for generating 3D models, and is especially useful for 3D printing applications.
In order to make the tests pass with our new ES module style imports I had to make the following changes:
Update tsd npm dependency
A couple minor type issues that surfaced
In three files I had to add @typedef for Mat4. I'm not sure why this was needed, but it did fix the issue.
Added V3 branch to the list of branches to run CI on
As part of updating the tsd dependency, it updated the lockfile version and caused a bunch of diff noise. I'm assuming it's because on my machine I used the latest node/npm/pnpm version.
All Submissions:
[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
This PR fixes the failing
tsdtest.In order to make the tests pass with our new ES module style imports I had to make the following changes:
tsdnpm dependency@typedefforMat4. I'm not sure why this was needed, but it did fix the issue.V3branch to the list of branches to run CI onAs part of updating the
tsddependency, it updated the lockfile version and caused a bunch of diff noise. I'm assuming it's because on my machine I used the latest node/npm/pnpm version.All Submissions: