feat(modeling): slice validation and measurement

jscad / OpenJSCAD.org

JSCAD is an open source set of modular, browser and command line tools for creating parametric 2D and 3D designs with JavaScript code. It provides a quick, precise and reproducible method for generating 3D models, and is especially useful for 3D printing applications.

https://openjscad.xyz/

MIT License

2.58k stars 505 forks source link

feat(modeling): slice validation and measurement #1282

Closed platypii closed 10 months ago

platypii commented 10 months ago

This PR continues the work of making slice a first class geometry for V3.

Adds validate function to slice geometry
Adds slice support to measurement functions
More test coverage

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass tests?

platypii commented 10 months ago

jscad.app already supports rendering V3 slices jscad-slice

platypii commented 10 months ago

@z3dev I added more comments and jsdoc.

I don't see how this would be any slower than before this refactor. Since it's doing the same caching, and there are no additional allocations versus before. Maybe the additional function calls to expand? Anyway I didn't see any performance hit, but you know I love to optimize performance, so if you see opportunity to improve, let me know!