Fix and Tests for CAG measurements and Poly3 measurements - Githubissues

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling

MIT License

218 stars 56 forks source link

Fix and Tests for CAG measurements and Poly3 measurements #108

Closed z3dev closed 5 years ago

z3dev commented 6 years ago

Additional tests were added to verify and test area calculations for both CAG and Polygon3.

Issues with Polygon3 were found when the polygon was 'concave' in shape. Fixes were made to use a faster routine for area calculations.

Note: measureArea.js was added for the new routine, which should be easy to integrate into V2.

All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Does your submission pass tests? (Including new tests)

z3dev commented 5 years ago

These are now part of V2 so closing.