Initial fixes and tests for poly3

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling

MIT License

218 stars 56 forks source link

Initial fixes and tests for poly3 #123

Closed z3dev closed 5 years ago

z3dev commented 6 years ago

These changes integrate fixes for poly3, as well as add tests for each of the functions.

[X] Update to ES6 - DONE
[X] Add tests for all functions - DONE, 95.78% coverage
[X] Add fixes for area - DONE

z3dev commented 6 years ago

The latest changes reverted the structure to use vertices, and consistently use vertices (vertex) across all functions. NOTE: The structure of poly3 is still not complete as color needs to be supported.

In addition, measureArea was corrected and tested (late V1 fixes).

z3dev commented 6 years ago

@kaosat-dev Do you know if these functions are required for poly3? I don't believe these are being used anywhere in the library.

measureBoundingBox.js measureBoundingSphere.js measureSignedVolume.js

kaosat-dev commented 6 years ago

@z3dev yes they are, but they still are called using the old .getBounds() calls which use all of those internally

z3dev commented 6 years ago

@kaosat-dev please reveiw again.

NOTE: measureSignedVolume is totally worthless, as planar polygons do not have volume.

z3dev commented 5 years ago

@kaosat-dev please review again.

this is done, and even beautified (as per eslint)

kaosat-dev commented 5 years ago

thanks for the tweaks & changes @z3dev ! Looks good to me !