`round` parameter in `rectangular_extrude` is unsupported - Githubissues

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling

MIT License

218 stars 56 forks source link

`round` parameter in `rectangular_extrude` is unsupported #131

Closed jonsadka closed 5 years ago

jonsadka commented 5 years ago

The rectangular_extrude API supports a round argument but the underlying method being called (Path2D.rectangularExtrude) does not

Code path:

rectangular_extrude(..., {round: false}) calls new Path2D(...).rectangularExtrude(..., ..., ..., round)) https://github.com/jscad/csg.js/blob/2ba12a38e020ae75404e184deed6a1aa0eccc6a0/src/api/ops-extrusions.js#L337
Path2D.rectangularExtrude only supports the following three arguments (width, height, resolution) https://github.com/jscad/csg.js/blob/2ba12a38e020ae75404e184deed6a1aa0eccc6a0/src/core/math/Path2.js#L169