Reorganized text into a module

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling

MIT License

218 stars 56 forks source link

Reorganized text into a module #168

Closed z3dev closed 5 years ago

z3dev commented 5 years ago

The goal of this pull request is to move the current text components into a module structure. The final code should be complete, 100% tested, reviewed, and ready for use in other functionality.

text
- [x] code complete
- [x] tests complete, 100% coverage
- [x] reviewed

z3dev commented 5 years ago

@kaosat-dev please review

I believe these functions should be dropped, as this is V2. :)

vector_char (replaced by vectorChar)
vector_text (replaced by vectorText)

kaosat-dev commented 5 years ago

I really like this ! I need to double check those two functions, I think there where some uses still

z3dev commented 5 years ago

I really like this ! I need to double check those two functions, I think there where some uses still

Maybe in the examples. But we will write new examples anyway.

z3dev commented 5 years ago

Maybe in the examples. But we will write new examples anyway.

Did a quick scan of the current distribution of OpenJSCAD.org. Those two functions are only found in the examples.

I think we can drop them in V2.

z3dev commented 5 years ago

I dropped the old code and fonts.

kaosat-dev commented 5 years ago

this all looks good to me @z3dev , shall I merge ?

z3dev commented 5 years ago

please merge. :)