search

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)
https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling
MIT License
217 stars 56 forks source link

Reorganization of Hulls #173

Closed z3dev closed 5 years ago

z3dev commented 5 years ago

This pull request adds the hull functions as a seperate module. The goals are:

hull

hullChain

z3dev commented 5 years ago

Is the module (directory) name correct? I think the module should be changed to 'hulls'.

@kaosat-dev Thoughts?

z3dev commented 5 years ago

@kaosat-dev please review

z3dev commented 5 years ago

@kaosat-dev please do a final review. and see the question above...

z3dev commented 5 years ago

BIG NEWS! I just added hull of path2 geometries, which returns the outline (path2) of the hulled points.

z3dev commented 5 years ago

@kaosat-dev This should be ready for merge now.

Unless... you want to add hull of geom3 geometries now.

kaosat-dev commented 5 years ago

Looks good to me @z3dev , thanks for the hard work ! Merging