Closed z3dev closed 4 years ago
The options to these functions may need some discussion.
@kaosat-dev please review.
@kaosat-dev
These functions may not be the best, but I don’t think there’s another choice for for V2.
Thoughts?
@z3dev I am still scratching my head around this one, not a fan indeed, not because of your code , but because this is imperative code, instead of descriptive like the rest of our code : it might be worth taking a look at how is handled in maker.js , I can take a go at possible solutions for this this week, and if that fails, then let's include this, we can always revisit later ?
@kaosat-dev any luck at a more expressive API?
If not then let’s take this as a priority in the next release.
@z3dev I have looked a bit into it , but not enough so here is the breakdown I still think it is a very weird / off part of our V1 api : IDEALLY we should follow the same logic as everywhere else:
HOWEVER I do not have more time to dig into it, and do not want to postpone/ block things because of that, so do you want us to merge this PR for now ?
Understood. I think the new API will use these for implementation.
For now, let's take this into V2. If fine, the please merge, @kaosat-dev
@kaosat-dev please merge. lets go with this initially.
This pull request adds the append functions to the path2 geometry, completing all functionality.
Note: As these functions only apply to the path2 geometry, these should therefore become part of the geometry.
appendArc
appendBezier
appendPoints