search

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)
https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling
MIT License
217 stars 56 forks source link

V2 - Fix of Rotate #179

Closed z3dev closed 5 years ago

z3dev commented 5 years ago

It seems that rotate() was completd before we committed on RADIANS for all angles. This pull request corrects that little error, and adjusts the test suites.

rotate:

P.S. I also fixed the GLOB parameter to ava in package.json. Way overdue.

z3dev commented 5 years ago

Yeah. I know what you mean, but I’m starting to do some designs with V2, and don’t find the switch to radians that difficult. Most of the time, I’m using simple angles like 90 degrees (Math.PI/2 radians). It’s rare that I do something really difficult with angles.

z3dev commented 5 years ago

Agreed. The switch to radians is the most significant change. But it makes the library better.

@kaosat-dev please merge.