jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)
https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling
MIT License
217 stars 56 forks source link

Reorganization of Connectors #181

Closed z3dev closed 5 years ago

z3dev commented 5 years ago

This pull request adds the connectors as a fully exposed seperate module. The goals are:

Connectors:

z3dev commented 5 years ago

Sadly, this still uses OrthoNormalBasis. I'm thinking that we should kill this soon as possible. There are only two uses now.

I think reTesselateCoplanarPolygons is overly complicated, and should be simplified. The use of to2D and to3D adds another area of imprecision to the point calculations. Maybe a task for later.

That leaves connectors using just getProjectionMatrix and getInverseProjectionMatrix. We could replace OrthoNormalBasis with the small function called toXYPlaneTransforms(). Thoughts?

z3dev commented 5 years ago

I added a new issue to follow up on removing OrthoNormalBasis in next pass. See Issue #184

@kaosat-dev please merge