V2 : Correcting use of 'size' parameter in primitives

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling

MIT License

218 stars 56 forks source link

V2 : Correcting use of 'size' parameter in primitives #189

Closed z3dev closed 5 years ago

z3dev commented 5 years ago

This pull request corrected the use / meaning of the 'size' parameter in the following primitives. Size now means full dimension, i.e. full width, length, depth, and height.

cube
cuboid
rectangle
roundedCuboid
roundedRectangle
square

All test suites that use these primitives have been adjusted as well.

z3dev commented 5 years ago

As discussed, I have made changes to correct the use / meaning of 'size'.

@kaosat-dev please review and merge

z3dev commented 5 years ago

This should be ready to go now.

@kaosat-dev please merge.