V2 : Enable torus primitive

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)

https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling

MIT License

217 stars 56 forks source link

V2 : Enable torus primitive #190

Closed z3dev closed 4 years ago

z3dev commented 4 years ago

These changes enable the torus primitive, which requires the extrudeRotate() function.

[X] code changes complete
[X] test coverage complete
[X] review complete

z3dev commented 4 years ago

By the way, I don’t think TORUS is a primitive because...

it doesn’t use math or geometry modules
it uses rotateExtrude(), which includes other modules, which includes other modules, etc.

If we want to keep this then it should be moved to extrusions, where it can live peacefully.

kaosat-dev commented 4 years ago

hmm extrusions is a set of operations, so that would not be a good fit either To me "primitive" does not describe how it is build, but more its geometric definition ? 'Shapes' would be a better fit ?

z3dev commented 4 years ago

Good suggestions. I’ll add a new issue to follow this up. For now, maybe we should just accept this.

kaosat-dev commented 4 years ago

Indeed !