search

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)
https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling
MIT License
218 stars 56 forks source link

Test cases and JSDOC comments for Path2D #52

Closed z3dev closed 7 years ago

z3dev commented 7 years ago

Hope that you like these!

kaosat-dev commented 7 years ago

Awesome PR @z3dev ! Lots of clean api documentation & updates! My only beef is innerToCAG itself, but good catch on finding it was missing in some cases. I think it might be possible to get rid of it/ an alternative to fromPoints I'll do some experiments. Merging this one in the meantime , great work !

PS: minor note: while merging I saw that there are docs, tests & fixes in the same PR, ideally we want to avoid that, since a PR should only 'add' or 'fix' a single thing