search

jscad / csg.js

DEPRECATED: CSG Library for JSCAD (See the link below)
https://github.com/jscad/OpenJSCAD.org/tree/master/packages/modeling
MIT License
218 stars 56 forks source link

fix(CAG): added back missing CAG.fromCompactBinary #91

Closed kaosat-dev closed 6 years ago

kaosat-dev commented 6 years ago

This PR fixes a MAJOR regression introduced in the last release that broke CAG.fromCompactBinary

z3dev commented 6 years ago

Cool. So, were the test cases correct?

kaosat-dev commented 6 years ago

@z3dev they were disabled as the object 'tags' were causing issues, but I added a simpler helper to sort that side out, and they worked fine :)