Onml svg serializer - Githubissues

jscad / io

DEPRECATED : Input Output handling for JSCAD (see the link below)

https://github.com/jscad/OpenJSCAD.org/tree/V2/packages

34 stars 13 forks source link

Onml svg serializer #39

Closed drom closed 6 years ago

drom commented 6 years ago

Rewrite using ONML library

z3dev commented 6 years ago

@drom I like this... The code is so much easy to maintain without all those "fake' XML tags.

Let's get a review from @kaosat-dev

kaosat-dev commented 6 years ago

I like the synax , very declarative, I will do a full review later but it looks good ! A few notes :

please keep your PRs clean and seperate, I can see the commit for your other PR in there ;-)
before we can merge this we need to create the unit tests: changing implementation before knowing if/what breaks is iffy ;-)

drom commented 6 years ago

@kaosat-dev Totally agree. Sorry, I have messed up first commit for the pull request, but I cleaned it with later commits. This PR contains only ONML proposal over svg-serializer. I have included single test for path New svg-serializercode has the same limited functionality as original and met to demonstrate ONML integration aspects only.

drom commented 6 years ago

Created clean version of PR in #41