search

jscad / io

DEPRECATED : Input Output handling for JSCAD (see the link below)
https://github.com/jscad/OpenJSCAD.org/tree/V2/packages
34 stars 13 forks source link

ONML Version of svg serializer #41

Closed drom closed 6 years ago

drom commented 6 years ago

Clean PR identical to https://github.com/jscad/io/pull/39

kaosat-dev commented 6 years ago

Thanks for this , much appreciated ! Very important question : do you know if onml works nicely when browserified and in a web worker ?

drom commented 6 years ago

Yes, I am testing ONML in node 0.10 ... 8.7.0 and browser (Firefox, Chrome).

kaosat-dev commented 6 years ago

ok cool. and web workers ? I will take this for a live spin before we can merge ok ? :)

drom commented 6 years ago

@kaosat-dev yes, workers should be fine. Do you use browserify? If yes, I can require ONML differently to include only stringify portion of the code, that will give smaller bundle.

z3dev commented 6 years ago

Cool! Thanks again, @drom

kaosat-dev commented 6 years ago

Yep , browserify for the main ui @drom thanks for the change! I am finally less swamped with work, so I can give this a closer look, sorry for the delay

z3dev commented 6 years ago

@drom We both like the improvement and the OMNL library, as XML should be avoided at all costs.

However, we don't have any tests. Are you interested in owning this library, and improving both the library and test cases? It shouldn't be hard, but we might ask for some changes.

drom commented 6 years ago

@z3dev If you mean ONML library, then I already own it. https://github.com/drom/onml I have tests, code coverage, run it in production and know several other users of it. And of cause you can always ask for changes of send me a pull request.

z3dev commented 6 years ago

@drom I never doubted. The ONML library looks very nice indeed.

I was hoping that you would like a small piece of the IO library. 😬

drom commented 6 years ago

@z3dev I would love to help. Being honest I am a newbie in the world of 3D and constructive solid geometry. I do have understanding of SVG, JS ecosystem and testing. I would need to learn more about capabilities that implemented / planed for IO library. For example: How primitives of one file format should be mapped back and forth into CSG primitives? or How 3D objects should be mapped back into 2D formats like SVG?

z3dev commented 6 years ago

Totally understood. I think both @kaosat-dev and I both consider ourselves novices. But learning fast because of the issues in the CSG library.

The whole 2D objectss, API, functions, etc is also creaking. Lots of potential but too few hands

For example, support for lines is critical for CNC users. That doesn't even exist today.

By the way, please grab us for a chat via Hangouts. We are available almost 24 hours due to our time zone differences. Would be fun.

z3dev commented 6 years ago

My account on Hangouts is the same as the Google+ group.

drom commented 6 years ago

@z3dev I can't find OpenJSCAD user on hangouts

z3dev commented 6 years ago

I don't think we have a groups setup. You can chat with me via jeff.gay@z3d.jp

z3dev commented 6 years ago

@drom It was good chatting with you. Can you resolve the conflicts with this PR, then I'll merge.

@kaosat-dev Do you have any comments or questions?

kaosat-dev commented 6 years ago

@drom would you be ok with updating this PR to solve the issues so that we can (finaly :) ) merge this ?

z3dev commented 6 years ago

@kaosat-dev Please do a final review, squash, and merge for release.

@drom Thanks

kaosat-dev commented 6 years ago

Looks good to me @drom , thanks for the changes! @z3dev merging ! Side note : I just saw we have a ton of 'vars' lying around instead of consts/lets , perhaps we should lint those in the future ? Not your fault at all @drom I am merging regardless ;)