search

jscad / io

DEPRECATED : Input Output handling for JSCAD (see the link below)
https://github.com/jscad/OpenJSCAD.org/tree/V2/packages
34 stars 13 forks source link

added node v9 #44

Closed drom closed 7 years ago

z3dev commented 7 years ago

Interesting.... have you tried the test suite of CSG.js with V9? If that works then we should start supporting V9 going forward.

kaosat-dev commented 7 years ago

I am a bit torn on this: v9 is barely a day old or so ... supporting LTS versions of node is one thing, the inbetween ones , perhaps not so much.

z3dev commented 7 years ago

@drom Are you willing to try all the libraries with V9? It would help @kaosat-dev sleep at night. :)

drom commented 7 years ago

@z3dev Yes, did run npm test on node v9.0.0 all pass. @kaosat-dev Node v9 is the main stable version now. Next LTS would be v10, not very soon. Adding v9 as pert of regression helps avoiding compatibility issues moving forward. IMHO

z3dev commented 7 years ago

Totally agree. Thanks again.

kaosat-dev commented 7 years ago

Ok , let's give it a chance then, thanks @drom :)